Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 18168: SQL std auth - authorize statements that work with paths


Copy link to this message
-
Re: Review Request 18168: SQL std auth - authorize statements that work with paths

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18168/#review34663

common/src/java/org/apache/hadoop/hive/common/FileUtils.java
<https://reviews.apache.org/r/18168/#comment64865>

    Better named as getPathOrParentThatExists()

common/src/java/org/apache/hadoop/hive/common/FileUtils.java
<https://reviews.apache.org/r/18168/#comment64864>

    Lot of this code is also present in HdfsAuthorizationProvider class, in authorize() method. Its worth checking if there can be code sharing here, not just for purpose of avoiding code duplication, but also to make sure there is consistent behavior in these two scenarios. I think it will make sense here to mimic HdfsAuthProvider here.

common/src/java/org/apache/hadoop/hive/common/FileUtils.java
<https://reviews.apache.org/r/18168/#comment64868>

    Perhaps the better test is path.getFileSystem() instanceof LocalFileSystem ?

ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/18168/#comment64869>

    Seems like new util method in FileUtils can be used here.

ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java
<https://reviews.apache.org/r/18168/#comment64870>

    Should this be Insert Priv, instead of Create ?
- Ashutosh Chauhan
On Feb. 17, 2014, 4:11 a.m., Thejas Nair wrote: