Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 18382: HIVE-3635: allow 't', 'T', '1', 'f', 'F', and '0' to be allowable true/false values for the boolean hive type


Copy link to this message
-
Re: Review Request 18382: HIVE-3635: allow 't', 'T', '1', 'f', 'F', and '0' to be allowable true/false values for the boolean hive type

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18382/

(Updated Feb. 21, 2014, 11:09 p.m.)
Review request for hive.
Bugs: HIVE-3635
    https://issues.apache.org/jira/browse/HIVE-3635
Repository: hive-git
Description

1. Implemented the functionality, allowing LazyBoolean to accepts these literals.
2. Added a configuration to control the functionality. Off by default.
Diffs (updated)

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 237b669
  conf/hive-default.xml.template f7f50e3
  data/files/bool_literal.txt PRE-CREATION
  ql/src/test/queries/clientpositive/bool_literal.q PRE-CREATION
  ql/src/test/results/clientpositive/bool_literal.q.out PRE-CREATION
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBoolean.java c741c3a
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 66f79ed
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySimpleSerDe.java 606208c
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBooleanObjectInspector.java 2cf7362
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java 5f64697

Diff: https://reviews.apache.org/r/18382/diff/
Testing

Added .q test which tests the behavior in cases of whether the functionality is turned on or not.
Thanks,

Xuefu Zhang