Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 18230: HIVE-6429 MapJoinKey has large memory overhead in typical cases


Copy link to this message
-
Re: Review Request 18230: HIVE-6429 MapJoinKey has large memory overhead in typical cases

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18230/#review35866

ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
<https://reviews.apache.org/r/18230/#comment66657>

    doesn't look like keyobject is used?

ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
<https://reviews.apache.org/r/18230/#comment66658>

    looks like unused import.

ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
<https://reviews.apache.org/r/18230/#comment66659>

    this still violates the coding standard as far as i can tell.

ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java
<https://reviews.apache.org/r/18230/#comment66660>

    same here.

serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
<https://reviews.apache.org/r/18230/#comment66663>

    this doesn't seem to belong here. it's not a general purpose serde method... in the vectorizedreducesink we seem to just break the row group into rows and serialize with the unchanged serde. can we do this here too?

serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
<https://reviews.apache.org/r/18230/#comment66662>

    this doesn't seem to belong in the serde. this is a helper for the map join key only. (e.g.: field < 8, etc) you should be able to just use the existing public interface, right?
- Gunther Hagleitner
On Feb. 28, 2014, 10:04 p.m., Sergey Shelukhin wrote: