Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 17691: Support Common Table Expressions (CTEs) in Hive


Copy link to this message
-
Re: Review Request 17691: Support Common Table Expressions (CTEs) in Hive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17691/#review33573
-----------------------------------------------------------

ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
<https://reviews.apache.org/r/17691/#comment63113>

    i thought multiple ctes are comma separated, no?

ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/17691/#comment63106>

    nit: you already have currDB to get the length.

ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/17691/#comment63107>

    i think having a comment for this block would be nice. i don't know what all is in qId. since you're trying multiple names is there a chance of collision?

ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/17691/#comment63109>

    nit: spaces

ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/17691/#comment63110>

    shouldn't views/ctesExpanded be sets?

ql/src/test/results/clientnegative/cte_recursion.q.out
<https://reviews.apache.org/r/17691/#comment63111>

    i like the error message. neat.
- Gunther Hagleitner
On Feb. 4, 2014, 3:39 a.m., Harish Butani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17691/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 3:39 a.m.)
>
>
> Review request for hive and Gunther Hagleitner.
>
>
> Bugs: HIVE-1180
>     https://issues.apache.org/jira/browse/HIVE-1180
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support Common Table Expressions (CTEs) in Hive
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 17f3552
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 3fbe8e2
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 719b496
>   ql/src/test/queries/clientnegative/cte_recursion.q PRE-CREATION
>   ql/src/test/queries/clientnegative/cte_with_in_subquery.q PRE-CREATION
>   ql/src/test/queries/clientpositive/cte_1.q PRE-CREATION
>   ql/src/test/queries/clientpositive/cte_2.q PRE-CREATION
>   ql/src/test/results/clientnegative/cte_recursion.q.out PRE-CREATION
>   ql/src/test/results/clientnegative/cte_with_in_subquery.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/cte_1.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/cte_2.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17691/diff/
>
>
> Testing
> -------
>
> added new tests
>
>
> Thanks,
>
> Harish Butani
>
>