Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 24962: HIVE-7730: Extend ReadEntity to add accessed columns from query


Copy link to this message
-
Re: Review Request 24962: HIVE-7730: Extend ReadEntity to add accessed columns from query

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24962/#review51554
Hi Xiaomeng, sorry for the long back and forth, but can you please fix these (especially the item we previously discussed)?
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/24962/#comment89960>

    Can you please remove this as per our previous discussion?  The construction of new linkedlist is not needed.

ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/24962/#comment89961>

    Please indent 2 spaces instead of 4.

ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/24962/#comment89962>

    Please indent 2 spaces.
- Szehon Ho
On Aug. 26, 2014, 2:22 a.m., Xiaomeng Huang wrote: