Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 18184: Vectorized mathematical functions for decimal type.


Copy link to this message
-
Re: Review Request 18184: Vectorized mathematical functions for decimal type.
Eric Hanson 2014-02-18, 23:45

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18184/#review34783

ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt
<https://reviews.apache.org/r/18184/#comment65070>

    format comment better (blank after //, blank line before first comment line)

ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt
<https://reviews.apache.org/r/18184/#comment65066>

    I think you could speed this up with an array fill operation for outputIsNull before the loop, but that is a nice-to-have and not essential.

ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt
<https://reviews.apache.org/r/18184/#comment65071>

    remove trailing white space

ql/src/gen/vectorization/ExpressionTemplates/DecimalColumnUnaryFunc.txt
<https://reviews.apache.org/r/18184/#comment65073>

    remove trailing white space

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
<https://reviews.apache.org/r/18184/#comment65132>

    Please add comment to explain what method does.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java
<https://reviews.apache.org/r/18184/#comment65136>

    delete trailing white space

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java
<https://reviews.apache.org/r/18184/#comment65137>

    delete trailing white space
    

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java
<https://reviews.apache.org/r/18184/#comment65138>

    fix comment format

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java
<https://reviews.apache.org/r/18184/#comment65139>

    remove trailing white space

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java
<https://reviews.apache.org/r/18184/#comment65140>

    remove trailing white space

ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestDecimalUtil.java
<https://reviews.apache.org/r/18184/#comment65144>

    please add cases for non-zero values close to 0 like -0.3 and 0.3
    
    for floor and ceiling

ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestDecimalUtil.java
<https://reviews.apache.org/r/18184/#comment65147>

    Please add test to negate 0 and make sure you still get 0

ql/src/test/queries/clientpositive/vector_decimal_math_funcs.q
<https://reviews.apache.org/r/18184/#comment65148>

    please remove trailing white space in .q file (several locations)
- Eric Hanson
On Feb. 17, 2014, 9:05 a.m., Jitendra Pandey wrote: