Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 18179: Support more generic way of using composite key for HBaseHandler


Copy link to this message
-
Re: Review Request 18179: Support more generic way of using composite key for HBaseHandler
Swarnim Kulkarni 2014-04-29, 21:01

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18179/#review41772

hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java
<https://reviews.apache.org/r/18179/#comment75357>

    @Navis - I am curious to know why this is setting a FamilyFilter here. I checked my original patch and this wasn't part of that.

hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java
<https://reviews.apache.org/r/18179/#comment75356>

    I had the following comment on my original patch for this method
    
    "/**
      * Validates the field in the {@link ExprNodeFieldDesc}. Basically this validates that the given field is the first field in the given struct. This is important specially in case of structs as order of fields in the structs is important when using for any filter down the line
      **/
    
    Since a composite key in HBase is essentially recognized by hive as a struct, this validation is to ensure that we are pushing down only the first field of that struct. This is important for proper setting of the scan object.
    
- Swarnim Kulkarni
On April 2, 2014, 6:28 a.m., Navis Ryu wrote: