Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 18168: SQL std auth - authorize statements that work with paths


Copy link to this message
-
Re: Review Request 18168: SQL std auth - authorize statements that work with paths

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18168/#review34608

common/src/java/org/apache/hadoop/hive/common/FileUtils.java
<https://reviews.apache.org/r/18168/#comment64773>

    standard is private static final

common/src/java/org/apache/hadoop/hive/common/FileUtils.java
<https://reviews.apache.org/r/18168/#comment64774>

    since we return in both the true and false case, this should just be:
    
    return permissions.getGroupAction().implies(action);

ql/src/java/org/apache/hadoop/hive/ql/security/SessionStateConfigUserAuthenticator.java
<https://reviews.apache.org/r/18168/#comment64775>

    why use negation in an if with an else? That makes the code confusing.
    
    It should be
    
    if (newUserName == null || newUserName.trim().isEmpty()) {
      return System...
    } else {
      return newUserName;
    }
    
    or even cleaner:
    
    String newUserName = ... get("user.name", "").trim();
    if(newUserName.isEmpty())
    ...
- Brock Noland
On Feb. 17, 2014, 4:11 a.m., Thejas Nair wrote: