Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 17262: HIVE-6246: Sign(a) UDF is not supported for decimal type


Copy link to this message
-
Re: Review Request 17262: HIVE-6246: Sign(a) UDF is not supported for decimal type
Swarnim Kulkarni 2014-01-27, 20:33

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17262/#review32876
-----------------------------------------------------------

ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java
<https://reviews.apache.org/r/17262/#comment61871>

    Nit: Add Javadoc.

ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java
<https://reviews.apache.org/r/17262/#comment61872>

    Nit: Add javadoc to this new method.
- Swarnim Kulkarni
On Jan. 23, 2014, 8:57 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17262/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2014, 8:57 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6246
>     https://issues.apache.org/jira/browse/HIVE-6246
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Please see the JIRA description. It's believed that this has nevered worked. Added a method in UDFSign class to handle Decimal data type to make it work. This method returns INT instead of doulbe to be inline with other data bases.
>
>
> Diffs
> -----
>
>   common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 729908a
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java 0fef283
>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSign.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17262/diff/
>
>
> Testing
> -------
>
> Unit test is added.
>
>
> Thanks,
>
> Xuefu Zhang
>
>