Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 20737: HIVE-6031: explain subquery rewrite for where clause predicates


Copy link to this message
-
Re: Review Request 20737: HIVE-6031: explain subquery rewrite for where clause predicates
Ashutosh Chauhan 2014-04-28, 18:28

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20737/#review41607
Few comments. Major one is to drop subquery from explain subquery rewrite syntax.
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainSQRewriteTask.java
<https://reviews.apache.org/r/20737/#comment75143>

    will be good to add a comment here for this replacement.

ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSQRewriteSemanticAnalyzer.java
<https://reviews.apache.org/r/20737/#comment75133>

    Is this needed ? Looks redundant code. If not, good to put some comments here.

ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
<https://reviews.apache.org/r/20737/#comment75132>

    I think we should not have explain subquery rewrite .. rather explain rewrite .. because later on we may want to extend this explain functionality beyond just subquery rewrites.

ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryDiagnostic.java
<https://reviews.apache.org/r/20737/#comment75146>

    Doesn't make lot of difference, but QBSQRewrite extends QBSQRewriteNoop seems more natural.

ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryDiagnostic.java
<https://reviews.apache.org/r/20737/#comment75147>

    Also, good to add a note here saying its non-explain path.
- Ashutosh Chauhan
On April 25, 2014, 10:57 p.m., Harish Butani wrote: