Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 24084: HIVE-7547 - Add ipAddress and userName to ExecHook


Copy link to this message
-
Re: Review Request 24084: HIVE-7547 - Add ipAddress and userName to ExecHook

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24084/#review49141

itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java
<https://reviews.apache.org/r/24084/#comment85986>

    if the hook does not run these two NPE. Let's have an assertion first for not null

ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/24084/#comment85987>

    Let's put this in javadoc format

service/src/java/org/apache/hive/service/cli/CLIService.java
<https://reviews.apache.org/r/24084/#comment85988>

    If this should not happen, should we throw these?
- Brock Noland
On July 30, 2014, 2:13 a.m., Szehon Ho wrote: