Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 24713: HIVE-7735 : Implement Char, Varchar in ParquetSerDe


Copy link to this message
-
Re: Review Request 24713: HIVE-7735 : Implement Char, Varchar in ParquetSerDe

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24713/#review50710
Looks good overall to me, one minor suggestion below.
ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java
<https://reviews.apache.org/r/24713/#comment88575>

    Can we put VCols in a set for more efficiency, and also can we use Guava's Iterables to make this logic cleaner?
- Szehon Ho
On Aug. 14, 2014, 10:53 p.m., Mohit Sabharwal wrote: