Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Re: Review Request 17718: Added special role PUBLIC.


Copy link to this message
-
Re: Review Request 17718: Added special role PUBLIC.

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17718/#review33629

itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
<https://reviews.apache.org/r/17718/#comment63170>

    trailing ws

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17718/#comment63172>

    I know it's not related but can we trim this ws?

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17718/#comment63173>

    An exception could be added when adding ADMIN and PUBLIC would not get added. Should these be separate cals?

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17718/#comment63175>

    Shouldn't this be true for admin? Should users be allowed to drop admin?
- Brock Noland
On Feb. 4, 2014, 7:31 p.m., Ashutosh Chauhan wrote: