Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 17718: Added special role PUBLIC.


Copy link to this message
-
Re: Review Request 17718: Added special role PUBLIC.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17718/#review33629
-----------------------------------------------------------

itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java
<https://reviews.apache.org/r/17718/#comment63170>

    trailing ws

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17718/#comment63172>

    I know it's not related but can we trim this ws?

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17718/#comment63173>

    An exception could be added when adding ADMIN and PUBLIC would not get added. Should these be separate cals?

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17718/#comment63175>

    Shouldn't this be true for admin? Should users be allowed to drop admin?
- Brock Noland
On Feb. 4, 2014, 7:31 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17718/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 7:31 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5960
>     https://issues.apache.org/jira/browse/HIVE-5960
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added special role PUBLIC.
>
>
> Diffs
> -----
>
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9ad5986
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 2d8e483
>   ql/src/test/queries/clientnegative/authorization_public_create.q PRE-CREATION
>   ql/src/test/queries/clientnegative/authorization_public_drop.q PRE-CREATION
>   ql/src/test/queries/clientnegative/authorize_grant_public.q PRE-CREATION
>   ql/src/test/queries/clientnegative/authorize_revoke_public.q PRE-CREATION
>   ql/src/test/results/clientnegative/authorization_fail_7.q.out 7bfb6e6
>   ql/src/test/results/clientnegative/authorization_public_create.q.out PRE-CREATION
>   ql/src/test/results/clientnegative/authorization_public_drop.q.out PRE-CREATION
>   ql/src/test/results/clientnegative/authorize_grant_public.q.out PRE-CREATION
>   ql/src/test/results/clientnegative/authorize_revoke_public.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/authorization_1.q.out 3391bcd
>   ql/src/test/results/clientpositive/authorization_1_sql_std.q.out a0b1ce0
>   ql/src/test/results/clientpositive/authorization_5.q.out 3aeaeca
>   ql/src/test/results/clientpositive/authorization_role_grant1.q.out 981060f
>   ql/src/test/results/clientpositive/authorization_view.q.out e74be93
>
> Diff: https://reviews.apache.org/r/17718/diff/
>
>
> Testing
> -------
>
> Added new test cases.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>