Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive >> mail # dev >> Review Request 19322: HIVE-6685 Beeline throws ArrayIndexOutOfBoundsException for mismatched arguments


+
Szehon Ho 2014-03-17, 21:39
+
Szehon Ho 2014-03-17, 21:41
+
Szehon Ho 2014-03-17, 22:56
+
Xuefu Zhang 2014-03-17, 21:44
+
Xuefu Zhang 2014-03-17, 22:15
+
Szehon Ho 2014-03-17, 21:56
+
Szehon Ho 2014-03-19, 01:25
+
Szehon Ho 2014-03-26, 19:42
Copy link to this message
-
Re: Review Request 19322: HIVE-6685 Beeline throws ArrayIndexOutOfBoundsException for mismatched arguments

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19322/

(Updated March 26, 2014, 8:32 p.m.)
Review request for hive and Xuefu Zhang.
Changes

Printing the Parser's output message.  Now prints as follows:

$./bin/beeline -u szehon -p
Missing argument for option: p
Usage: java org.apache.hive.cli.beeline.BeeLine
   -u <database url>               the JDBC URL to connect to
   -n <username>                   the username to connect as
   -p <password>                   the password to connect as
   -d <driver class>               the driver class to use
   -e <query>                      query that should be executed
   -f <file>                       script file that should be executed
   --hiveconf property=value       Use value for given property
   --hivevar name=value            hive variable name and value
                                   This is Hive specific settings in which variables
                                   can be set at session level and referenced in Hive
                                   commands or queries.
   --color=[true/false]            control whether color is used for display
   --showHeader=[true/false]       show column names in query results
   --headerInterval=ROWS;          the interval between which heades are displayed
   --fastConnect=[true/false]      skip building table/column list for tab-completion
   --autoCommit=[true/false]       enable/disable automatic transaction commit
   --verbose=[true/false]          show verbose error messages and debug info
   --showWarnings=[true/false]     display connection warnings
   --showNestedErrs=[true/false]   display nested errors
   --numberFormat=[pattern]        format numbers using DecimalFormat pattern
   --force=[true/false]            continue running script even after errors
   --maxWidth=MAXWIDTH             the maximum width of the terminal
   --maxColumnWidth=MAXCOLWIDTH    the maximum width to use when displaying columns
   --silent=[true/false]           be more silent
   --autosave=[true/false]         automatically save preferences
   --outputformat=[table/vertical/csv/tsv]   format mode for result display
   --isolation=LEVEL               set the transaction isolation level
   --nullemptystring=[true/false]  set to true to get historic behavior of printing null as empty string
   --help                          display this message
Bugs: HIVE-6685
    https://issues.apache.org/jira/browse/HIVE-6685
Repository: hive-git
Description

Improving the error-handling in ArrayIndexOutOfBoundsException of Beeline.
Diffs (updated)

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 1bd7af3
  beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java PRE-CREATION

Diff: https://reviews.apache.org/r/19322/diff/
Testing

Manual test.  Now, in this scenario it will display the usage like:

beeline -u
Usage: java org.apache.hive.cli.beeline.BeeLine
   -u <database url>               the JDBC URL to connect to
   -n <username>                   the username to connect as
   -p <password>                   the password to connect as
...
Thanks,

Szehon Ho
 
+
Xuefu Zhang 2014-03-27, 03:10
+
Xuefu Zhang 2014-03-26, 20:03