Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 20051: HIVE-4904: A little more CP crossing RS boundaries


Copy link to this message
-
Re: Review Request 20051: HIVE-4904: A little more CP crossing RS boundaries

Thanks John.Here are responses to your points

1. Column Pruner doesn't cross Script operator boundary.
  The ColumnPrunerWalker explicitly stops at the SelectOp parent of a ScriptOp. This may have been ok when developed; as you point out now it makes sense to continue pruning on the SelectOp ancestors. Can you file a jira for this.
2. The check in ColumnPrunerSelectProc is needed for the LVJoin case, where for the UDTFOp you end up with a empty PrunedList. What I realized was that Navis's fix doesn't cover the LVJoin case. Yes this should be revisited.  
- Harish
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20051/#review39706
On April 6, 2014, 1:33 a.m., Harish Butani wrote: