Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 20243: HIVE-6891 - Alter rename partition Perm inheritance and general partition/table owner inheritance


Copy link to this message
-
Re: Review Request 20243: HIVE-6891 - Alter rename partition Perm inheritance and general partition/table owner inheritance

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20243/

(Updated April 12, 2014, 11:50 p.m.)
Review request for hive.
Changes

This patch passes the test for both hadoop profiles.  Making the test use the hadoop-shims, to handle listFile non-existent API in hadoop 0.20.
Bugs: HIVE-6891
    https://issues.apache.org/jira/browse/HIVE-6891
Repository: hive-git
Description

This is a follow-up of HIVE-6648.

Extending the fix to other partition/table operations as well, by refactoring the fixed code in HIVE-6648 into a common FileUtils helper method, and then using it for all table/partition directory creation operation, when "hive.warehouse.subdir.inherit.perms" flag is set.  

Another part of this change is to add ownership inheritance in this code as well when creating directories.  Ownership was already inherited for data (HIVE-3756), but not at the table/partitioned-table level.
Diffs (updated)

  common/src/java/org/apache/hadoop/hive/common/FileUtils.java ad82f62
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 47e94ea
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java f1c7b7b
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 8345d70
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c62e085
  metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java f731dab
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2559e0e

Diff: https://reviews.apache.org/r/20243/diff/
Testing

Extending the unit test TestFolderPermission to handle all the new cases of directory creation (create table, external table, static partition, dynamic partition, rename partition).

Unfortunately due to the test using the local file system, I cannot add the ownership inheritance to unit-testing.  I can probably look into using MiniDFS for that, in a follow-up JIRA.
Thanks,

Szehon Ho