-Re: Review Request 20243: HIVE-6891 - Alter rename partition Perm inheritance and general partition/table owner inheritance
Szehon Ho 2014-04-12, 23:51
This is an automatically generated e-mail. To reply, visit:
(Updated April 12, 2014, 11:50 p.m.)
Review request for hive.
This patch passes the test for both hadoop profiles. Making the test use the hadoop-shims, to handle listFile non-existent API in hadoop 0.20.
This is a follow-up of HIVE-6648.
Extending the fix to other partition/table operations as well, by refactoring the fixed code in HIVE-6648 into a common FileUtils helper method, and then using it for all table/partition directory creation operation, when "hive.warehouse.subdir.inherit.perms" flag is set.
Another part of this change is to add ownership inheritance in this code as well when creating directories. Ownership was already inherited for data (HIVE-3756), but not at the table/partitioned-table level.
Extending the unit test TestFolderPermission to handle all the new cases of directory creation (create table, external table, static partition, dynamic partition, rename partition).
Unfortunately due to the test using the local file system, I cannot add the ownership inheritance to unit-testing. I can probably look into using MiniDFS for that, in a follow-up JIRA.