Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates


Copy link to this message
-
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
Brock Noland 2014-01-27, 23:52

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17163/#review32912
-----------------------------------------------------------

ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/17163/#comment61936>

    Anytime we are doing a switch on an enum and the default condition is illegal, the default should throw AssertionError().

ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/17163/#comment61939>

    Thanks for cleaning this up!

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java
<https://reviews.apache.org/r/17163/#comment61937>

    same

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java
<https://reviews.apache.org/r/17163/#comment61938>

    same

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17163/#comment61943>

    space missing in error message

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17163/#comment61940>

    same
- Brock Noland
On Jan. 27, 2014, 11:22 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17163/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2014, 11:22 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-5929
>     https://issues.apache.org/jira/browse/HIVE-5929
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Subtask for sql standard based auth, for performing the updates to metastore from newly supported access  control statements .
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java cb0c1a5
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28
>   ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec
>   ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION
>   ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5
>   ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c
>
> Diff: https://reviews.apache.org/r/17163/diff/
>
>
> Testing
>