Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 17509: Authorize create / drop / show roles


Copy link to this message
-
Re: Review Request 17509: Authorize create / drop / show roles

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17509/#review33159
-----------------------------------------------------------

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17509/#comment62462>

    These fields should be final

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17509/#comment62461>

    What exactly does HiveAuthorizationPluginException represent? Looks to me like it represents both access denied and "error". If that is in fact true I think it's a mistake.

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17509/#comment62460>

    style

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17509/#comment62457>

    ws

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17509/#comment62459>

    style

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17509/#comment62463>

    constant should be declared somewhere

ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/17509/#comment62458>

    style
- Brock Noland
On Jan. 29, 2014, 8:30 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17509/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 8:30 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5944
>     https://issues.apache.org/jira/browse/HIVE-5944
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Authorize create / drop / show roles
>
>
> Diffs
> -----
>
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 9fe2a06
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 5a16a4a
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 44dd161
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java 7425150
>
> Diff: https://reviews.apache.org/r/17509/diff/
>
>
> Testing
> -------
>
> Will update tests once HIVE-5959 is checked-in.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>