Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 23800: HIVE-7470: Wrong Thrift declaration for {{ShowCompactResponseElement}}


Copy link to this message
-
Review Request 23800: HIVE-7470: Wrong Thrift declaration for {{ShowCompactResponseElement}}

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23800/

Review request for hive.
Bugs: HIVE-7470
    https://issues.apache.org/jira/browse/HIVE-7470
Repository: hive-git
Description

HIVE-7470 Wrong Thrift declaration for {{ShowCompactResponseElement}}

ShowCompactResponseElement declaration fix all fields required but ACID code use table with null-able columns.

This throw exceptions in Thirft stack when calling show_compact() on remote metastore.

This patch is very simple, it change definition of null-able properties to optional Thrift property.
Diffs

  metastore/if/hive_metastore.thrift 55f41db
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h f352cd5
  metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp a6a40fd
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java 4547970
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java 68a4219
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatistics.java 6aecf26
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsResult.java a4ae892
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Function.java 781281a
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsInfoResponse.java b782d32
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsResponse.java d549ce9
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPrincipalsInRoleResponse.java 3ef6224
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetRoleGrantsForPrincipalResponse.java 3ddc1ac
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeResponse.java f3e3c07
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java b22b211
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java cdf6f30
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java 54955c6
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java 7d29d09
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java 5ea5a1b
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java 80a151a
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java 537db47
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java 0c9518a
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java 4285ed8
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java 2fcb216
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java 58e9028
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java b962e27
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponseElement.java 47da9b3
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java 1399f8b
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java ab5c0ed
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java 813b4f0
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 484bd6a
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java ddfcccc
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java e37b75c
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1e0cdea
  metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Type.java 1882b57
  metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py c71b7b7
  metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb e21f662

Diff: https://reviews.apache.org/r/23800/diff/
Testing
Thanks,

Damien Carol