Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 24289: MetadataUpdater: provide a mechanism to edit the statistics of a column in a table (or a partition of a table)


Copy link to this message
-
Re: Review Request 24289: MetadataUpdater: provide a mechanism to edit the statistics of a column in a table (or a partition of a table)

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24289/#review49571
I've only done a partial review as there seem to be a lot of minor unrelated changes and whitespace problems in here. I'll do a full one as soon as that's fixed.
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/24289/#comment86716>

    All of these are tabs and not needed changes

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
<https://reviews.apache.org/r/24289/#comment86717>

    whitespace only changes

metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java
<https://reviews.apache.org/r/24289/#comment86718>

    tabs instead of spaces in this file

metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java
<https://reviews.apache.org/r/24289/#comment86719>

    missing braces for all these if statements

ql/.gitignore
<https://reviews.apache.org/r/24289/#comment86720>

    Unless I'm mistaken there is no bin folder in ql?

ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java
<https://reviews.apache.org/r/24289/#comment86721>

    Still using tabs instead of spaces here

ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java
<https://reviews.apache.org/r/24289/#comment86722>

    no need to wrap

ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java
<https://reviews.apache.org/r/24289/#comment86723>

    unrelated whitespace changes

ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java
<https://reviews.apache.org/r/24289/#comment86724>

    unrelated
- Lars Francke
On Aug. 5, 2014, 1:41 a.m., pengcheng xiong wrote: