Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.


Copy link to this message
-
Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types.
Eric Hanson 2014-03-28, 22:45

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19718/#review38958

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java
<https://reviews.apache.org/r/19718/#comment71328>

    please add a comment to explain why we use the sum of all the counts here to determine the array size.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java
<https://reviews.apache.org/r/19718/#comment71329>

    Consider for readability/encapsulation having a function to compute offset, e.g.
    
    isNull[decimalOffset(index)] = false;
    
    Please add a comment to explain offset logic.
    
    Does addition of decimal affect any other offsets? I guess not.

ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java
<https://reviews.apache.org/r/19718/#comment71330>

    Timestamp is supposed to be represented as a long (# of nanos since epoch). So whey is this using a FilterStringColumnBetween?

ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java
<https://reviews.apache.org/r/19718/#comment71331>

    Again, why string and not long "not between" operator?
- Eric Hanson
On March 28, 2014, 9:56 p.m., Jitendra Pandey wrote: