Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Re: Review Request 19165: HIVE-6643: Add a check for cross products in plans and output a warning


Copy link to this message
-
Re: Review Request 19165: HIVE-6643: Add a check for cross products in plans and output a warning

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19165/#review37151

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CrossProductCheck.java
<https://reviews.apache.org/r/19165/#comment68541>

    this should say CrossProductCheck.class

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CrossProductCheck.java
<https://reviews.apache.org/r/19165/#comment68543>

    I think you'll always have at least one element - but that's not super obvious. a check for empty might be the defensive choice.

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CrossProductCheck.java
<https://reviews.apache.org/r/19165/#comment68544>

    wondering if we should just simplify this and not go hunt for bigtable at all.

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CrossProductCheck.java
<https://reviews.apache.org/r/19165/#comment68545>

    not sure if the coding guidelines require uppercase/camelcase inner classes...

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java
<https://reviews.apache.org/r/19165/#comment68546>

    i'm fine with this. but most folks put bug defense flag check in "optimizers". might help if this turns out to be expensive or if it fails for some reason. (definitely should be on by default tho).
- Gunther Hagleitner
On March 12, 2014, 11:58 p.m., Harish Butani wrote: