Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 21138: Support more generic way of using composite key for HBaseHandler


Copy link to this message
-
Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler
Swarnim Kulkarni 2014-05-12, 06:43

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21138/#review42667

hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java
<https://reviews.apache.org/r/21138/#comment76491>

    That said, I am also not a 100% positive on why Navis chose a FamilyFilter here. In my latest patch, I updated the setupFilter method to be protected so that it can be easily overridden. I'll ask Navis for his choice of FamilyFilter here. If we don't get a response, my vote will be to proceed with the "protected" scope of this method and log a follow up JIRA to clean this up.
- Swarnim Kulkarni
On May 8, 2014, 3:42 p.m., Swarnim Kulkarni wrote: