Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Re: VOTE: Remove phabricator instructions from hive-development guide (wiki), officially only support Apache's review board.


Copy link to this message
-
Re: VOTE: Remove phabricator instructions from hive-development guide (wiki), officially only support Apache's review board.
Good call, I made a very basic fix and noted on the Phabricator page that
it's no longer used.

Brock
On Thu, Jan 23, 2014 at 3:32 PM, Lefty Leverenz <[EMAIL PROTECTED]>wrote:

> The wiki still has Phabricator information, with nothing about Apache's
> review board.
>
> How to Contribute:  Review
> Process<
> https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-ReviewProcess
> >
> >
>
>
> See Phabricator<
> https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview>
> for
> > instructions.
> >
> >    - Use Hadoop's code review checklist<
> http://wiki.apache.org/hadoop/CodeReviewChecklist> as
> >    a rough guide when doing reviews.
> >
> >
> >    - In JIRA, use 'Submit Patch' to get your review request into the
> >    queue.
> >
> >
> >    - If a committer requests changes, set the issue status to 'Resume
> >    Progress', then once you're ready, submit an updated patch with
> necessary
> >    fixes and then request another round of review with 'Submit Patch'
> again.
> >
> >
> >    - Once your patch is accepted, be sure to upload a final version which
> >    grants rights to the ASF.
> >
> >
> Would someone please update this section with the appropriate link to
> review board instructions?  I'm a review board newbie (or wanna-be) but
> can't even get registration to work so I won't volunteer.  Should the link
> go to http://www.reviewboard.org/docs/manual/1.7/?
>
>
> -- Lefty
>
>
> On Sat, Oct 19, 2013 at 12:10 PM, Prasad Mujumdar <[EMAIL PROTECTED]
> >wrote:
>
> >     +1 (non-binding)
> > Its good to use a common review tool and one that's has no third party
> > dependency.
> >
> > thanks
> > Prasad
> >
> >
> >
> >
> > On Fri, Oct 18, 2013 at 1:59 PM, Ashutosh Chauhan <[EMAIL PROTECTED]
> > >wrote:
> >
> > > 0
> > >
> > > IMO phabricator interface is better than review board, but threat of
> > losing
> > > comments and patches is also real.
> > > Actually, we already lost in few cases, ironically it was RB. Try to
> read
> > > the very first review request posted on HIVE-1634
> > >
> > > Ashutosh
> > >
> > >
> > > On Thu, Oct 17, 2013 at 6:55 PM, Yin Huai <[EMAIL PROTECTED]>
> wrote:
> > >
> > > > +1
> > > >
> > > >
> > > > On Thu, Oct 17, 2013 at 5:51 PM, Gunther Hagleitner <
> > > > [EMAIL PROTECTED]> wrote:
> > > >
> > > > > +1
> > > > >
> > > > > Thanks,
> > > > > Gunther.
> > > > >
> > > > >
> > > > > On Thu, Oct 17, 2013 at 2:18 PM, Owen O'Malley <[EMAIL PROTECTED]
> >
> > > > wrote:
> > > > >
> > > > > > Ed,
> > > > > >   I didn't remember being unable to see revisions without a
> login.
> > > That
> > > > > is
> > > > > > uncool. I'll change my vote to +1.
> > > > > >
> > > > > > -- Owen
> > > > > >
> > > > > >
> > > > > > On Wed, Oct 16, 2013 at 9:08 PM, Edward Capriolo <
> > > > [EMAIL PROTECTED]
> > > > > > >wrote:
> > > > > >
> > > > > > > Owen,
> > > > > > > In your issues:
> > > > > > > https://issues.apache.org/jira/browse/HIVE-5567
> > > > > > >
> > > > > > > When I click this link:
> > > > > > > REVISION DETAIL
> > > > > > > https://reviews.facebook.net/D13479
> > > > > > >
> > > > > > > I am prompted for a password.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Oct 16, 2013 at 11:16 PM, Owen O'Malley <
> > > > > [EMAIL PROTECTED]
> > > > > > > >wrote:
> > > > > > >
> > > > > > > > -0
> > > > > > > >
> > > > > > > > I like phabricator, but it is a pain to setup. It doesn't
> > > require a
> > > > > fb
> > > > > > > > account, but clearly it isn't managed or supported by Apache.
> > > > > > > >
> > > > > > > > -- Owen
> > > > > > > >
> > > > > > > > > On Oct 16, 2013, at 17:32, Edward Capriolo <
> > > > [EMAIL PROTECTED]>
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Our wiki has instructions for posting to phabricator for
> code
> > > > > > reviews.
> > > > > > > > >
> > > > > >
> > > https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview
> > > > > > > > >
> > > > > > > > > Phabricator now requires an external facebook account to

Apache MRUnit - Unit testing MapReduce - http://mrunit.apache.org

 
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB