-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8285/#review13949
-----------------------------------------------------------

Ship it!
Thank you Bilung for your time and effort. It looks good to me, please attach the patch to the JIRA and I'll commit it.

- Jarek Cecho
On Nov. 29, 2012, 11:41 p.m., Bilung Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8285/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2012, 11:41 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Develop framework-defined partitioners/extractors that provide common functionality to extract data from text/sequence files of HDFS in uncompressed/compressed modes
>
>
> This addresses bug SQOOP-705.
>     https://issues.apache.org/jira/browse/SQOOP-705
>
>
> Diffs
> -----
>
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/PrefixContext.java 5488b46
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartition.java PRE-CREATION
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartitioner.java PRE-CREATION
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java PRE-CREATION
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java PRE-CREATION
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8285/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bilung Lee
>
>

> On Dec. 1, 2012, 9:15 p.m., Jarek Cecho wrote:
> > Thank you Bilung for your time and effort. It looks good to me, please attach the patch to the JIRA and I'll commit it.

Thanks for your review!  Patch is attached.
- Bilung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8285/#review13949
-----------------------------------------------------------
On Nov. 29, 2012, 11:41 p.m., Bilung Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8285/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2012, 11:41 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Develop framework-defined partitioners/extractors that provide common functionality to extract data from text/sequence files of HDFS in uncompressed/compressed modes
>
>
> This addresses bug SQOOP-705.
>     https://issues.apache.org/jira/browse/SQOOP-705
>
>
> Diffs
> -----
>
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/PrefixContext.java 5488b46
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartition.java PRE-CREATION
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartitioner.java PRE-CREATION
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceExportExtractor.java PRE-CREATION
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextExportExtractor.java PRE-CREATION
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8285/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bilung Lee
>
>