Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: Fix for SQOOP-1029


+
Venkat Ranganathan 2013-05-04, 23:54
+
Venkat Ranganathan 2013-05-06, 05:04
+
Jarek Cecho 2013-05-20, 13:15
+
Jarek Cecho 2013-05-20, 13:15
Copy link to this message
-
Re: Review Request: Fix for SQOOP-1029
Jarek Cecho 2013-05-06, 04:32

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10943/#review20173
-----------------------------------------------------------
Hi Venkat,
good catch! I have just two nits:
src/java/org/apache/sqoop/manager/OracleManager.java
<https://reviews.apache.org/r/10943/#comment41410>

    Do you think that we can use StringUtils.join(collection, ",") instead of the "Arrays.toString()?

src/java/org/apache/sqoop/manager/SqlManager.java
<https://reviews.apache.org/r/10943/#comment41409>

    Do you think that we can use StringUtils.join(collection, ",") instead of the "Arrays.toString()?
Jarcec

- Jarek Cecho
On May 4, 2013, 11:54 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10943/
> -----------------------------------------------------------
>
> (Updated May 4, 2013, 11:54 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Provides an overridden implementation to get column names and types that obeys the way Oracle DBMetadata provides procedure metadata
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/manager/OracleManager.java 1999344
>   src/java/org/apache/sqoop/manager/SqlManager.java 6952b9e
>
> Diff: https://reviews.apache.org/r/10943/diff/
>
>
> Testing
> -------
>
> Tested with Oracle 11g
>
>
> Thanks,
>
> Venkat Ranganathan
>
>

+
Venkat Ranganathan 2013-05-06, 05:04
+
Shruti Joshi 2013-05-10, 12:06
+
Jarek Cecho 2013-05-21, 08:56
+
Shruti Joshi 2013-05-23, 07:55
+
Shruti Joshi 2013-05-23, 07:52
+
Shruti Joshi 2013-05-22, 13:22
+
Shruti Joshi 2013-05-27, 11:22
+
Jarek Cecho 2013-05-28, 10:24
+
Jarek Cecho 2013-05-29, 06:54
+
Shruti Joshi 2013-05-28, 12:16
+
Shruti Joshi 2013-05-30, 13:12
+
Shruti Joshi 2013-06-03, 13:06
+
Shruti Joshi 2013-06-03, 13:04
+
Jarek Cecho 2013-06-08, 16:19
+
Shruti Joshi 2013-06-19, 10:12
+
Shruti Joshi 2013-06-19, 10:17
+
Jarek Cecho 2013-06-19, 20:50
+
Venkat Ranganathan 2013-05-21, 01:00
+
Venkat Ranganathan 2013-05-21, 04:09
+
Jarek Cecho 2013-05-21, 08:39
+
Venkat Ranganathan 2013-05-21, 16:42
+
Venkat Ranganathan 2013-05-21, 18:57
+
Jarek Cecho 2013-05-22, 06:31
+
Venkat Ranganathan 2013-05-30, 06:07
+
Venkat Ranganathan 2013-05-30, 18:25
+
Abraham Elmahrek 2013-05-31, 20:30
+
Venkat Ranganathan 2013-06-01, 00:07
+
Abraham Elmahrek 2013-05-31, 20:33
+
Jarek Cecho 2013-06-10, 15:36
+
Venkat Ranganathan 2013-06-10, 16:06
+
Venkat Ranganathan 2013-06-11, 18:41
+
Venkat Ranganathan 2013-06-12, 17:23
+
Venkat Ranganathan 2013-06-13, 05:46
+
Abraham Elmahrek 2013-06-13, 19:00
+
Venkat Ranganathan 2013-06-13, 20:32
+
Jarek Cecho 2013-06-13, 20:35
+
Abraham Elmahrek 2013-06-13, 01:41
+
Venkat Ranganathan 2013-06-13, 05:44
+
Venkat Ranganathan 2013-06-19, 21:48