Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-529: Enforce usage of --driver and --connection-manager parameters


+
Jarek Cecho 2012-07-31, 20:52
+
Abhijeet Gaikwad 2012-08-01, 04:11
+
Jarek Cecho 2012-08-01, 16:02
+
Abhijeet Gaikwad 2012-08-01, 16:51
+
Jarek Cecho 2012-08-01, 16:58
+
Jarek Cecho 2012-08-01, 16:03
+
Abhijeet Gaikwad 2012-08-01, 18:37
+
Jarek Cecho 2012-08-02, 00:37
Copy link to this message
-
Re: Review Request: SQOOP-529: Enforce usage of --driver and --connection-manager parameters
Bilung Lee 2012-08-02, 21:48

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6250/#review9788
-----------------------------------------------------------

Ship it!

/src/java/org/apache/sqoop/ConnFactory.java
<https://reviews.apache.org/r/6250/#comment20778>

    One nit: add a space before the word "Sqoop".
- Bilung Lee
On Aug. 1, 2012, 4:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6250/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2012, 4:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've refactored the code in the way I've designed in the JIRA.
>
>
> This addresses bug SQOOP-529.
>     https://issues.apache.org/jira/browse/SQOOP-529
>
>
> Diffs
> -----
>
>   /src/java/org/apache/sqoop/ConnFactory.java 1367605
>   /src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 1367605
>
> Diff: https://reviews.apache.org/r/6250/diff/
>
>
> Testing
> -------
>
> ant tests passes
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Jarek Cecho 2012-08-02, 23:00