Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Zookeeper >> mail # dev >> Re: Review Request 12983: ZOOKEEPER-1691


Copy link to this message
-
Re: Review Request 12983: ZOOKEEPER-1691

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12983/#review26642
-----------------------------------------------------------

http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
<https://reviews.apache.org/r/12983/#comment51893>

    Hi Helen,
    
    What I would expect to happen in the scenario you described is the following: the joining server has a configuration with 2 servers, however its version is 0. Therefore when it gets a message from the single server currently in the ensemble, with version > 0 (is this true ?), its quorum verifier is replaced with the one received in the message. Then 1 out of 1 voting messages is a quorum and it can complete leader election phase.
    
    It may be that you're not getting a message with version > 0, I'm not sure. I'll continue looking at this too.
    
- Alexander Shraer
On Aug. 21, 2013, 10:11 p.m., Helen Hastings wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12983/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2013, 10:11 p.m.)
>
>
> Review request for zookeeper and Alexander Shraer.
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> Added standaloneEnabled flag to QuorumPeerConfig to give the option to disable standalone mode for a single server.
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java PRE-CREATION
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StandaloneTest.java 1516310
>
> Diff: https://reviews.apache.org/r/12983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Helen Hastings
>
>