Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-416. Allow code-generation arguments with Avro imports


Copy link to this message
-
Re: Review Request: SQOOP-416. Allow code-generation arguments with Avro imports
Bilung Lee 2012-03-05, 19:03

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4161/#review5618
-----------------------------------------------------------

Ship it!
Thanks for the patch, Kyryl!

- Bilung
On 2012-03-05 09:58:09, Kyryl Bilokurov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4161/
> -----------------------------------------------------------
>
> (Updated 2012-03-05 09:58:09)
>
>
> Review request for Sqoop and Bilung Lee.
>
>
> Summary
> -------
>
> This is pretty trivial patch, it just introduces new variables for the name and namespace in Avro schema and initializes them to the values passed in the options in the manner similar to ClassWriter.
>
>
> This addresses bug SQOOP-416.
>     https://issues.apache.org/jira/browse/SQOOP-416
>
>
> Diffs
> -----
>
>   ./src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 1296327
>
> Diff: https://reviews.apache.org/r/4161/diff
>
>
> Testing
> -------
>
> Import and export of Avro data files from/to SQL table.
>
>
> Thanks,
>
> Kyryl
>
>