Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper, mail # dev - Re: Review Request 12983: ZOOKEEPER-1691


+
Helen Hastings 2013-08-19, 21:26
+
Edward Ribeiro 2013-08-20, 00:39
+
Helen Hastings 2013-08-21, 22:09
+
Edward Ribeiro 2013-08-20, 02:00
+
Edward Ribeiro 2013-08-20, 02:03
+
Edward Ribeiro 2013-08-20, 02:02
Copy link to this message
-
Re: Review Request 12983: ZOOKEEPER-1691
Edward Ribeiro 2013-08-20, 02:08

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12983/#review25334
-----------------------------------------------------------

http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
<https://reviews.apache.org/r/12983/#comment49719>

    Extract this as a field:
    
    private final int NUM_SERVERS = 5;
    
    so that it can be reused by smaller utilitary functions.

http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java
<https://reviews.apache.org/r/12983/#comment49720>

    Make lines 60-68 into a private method as below, e.g.:
    
    private List<String> buildServerStrings() {
    
       ArrayList<String> serverStrings = new ArrayList<String>();
    
      for (int i = 0; i < NUM_SERVERS; i++) {
         clientPorts[i] = PortAssignment.unique();
         String server = "server." + i + "=localhost:"+PortAssignment.unique()+":"+PortAssignment.unique()
                       +   ":participant;"
                       + "localhost:"   + clientPorts[i];
                   serverStrings.add(server);
      }
      return serverStrings;
    }
    
    So, at line 60 you can just call the method.
    
- Edward Ribeiro
On Aug. 19, 2013, 9:26 p.m., Helen Hastings wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12983/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 9:26 p.m.)
>
>
> Review request for zookeeper and Alexander Shraer.
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> Added standaloneEnabled flag to QuorumPeerConfig to give the option to disable standalone mode for a single server.
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java PRE-CREATION
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java 1515597
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StandaloneTest.java 1515597
>
> Diff: https://reviews.apache.org/r/12983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Helen Hastings
>
>

+
Edward Ribeiro 2013-08-20, 02:25
+
Edward Ribeiro 2013-08-20, 02:13
+
Edward Ribeiro 2013-08-20, 02:31
+
Helen Hastings 2013-08-21, 22:11
+
Edward Ribeiro 2013-08-22, 00:14
+
Helen Hastings 2013-08-21, 22:11
+
Alexander Shraer 2013-08-30, 11:11
+
Helen Hastings 2013-10-01, 04:02
+
Alexander Shraer 2013-10-03, 04:54
+
Helen Hastings 2013-12-14, 00:00
+
Helen Hastings 2013-12-14, 00:02
+
Helen Hastings 2014-01-07, 04:32
+
Raul Gutierrez Segales 2014-01-17, 18:51