Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1893. File Channel could miss possible checkpoint corruption


Copy link to this message
-
Review Request: FLUME-1893. File Channel could miss possible checkpoint corruption

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9266/
-----------------------------------------------------------

Review request for Flume.
Description
-------

Made sure the comparisons made are long comparisons and we don't miss the Most significant 4 bytes.
This addresses bug FLUME-1893.
    https://issues.apache.org/jira/browse/FLUME-1893
Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 7f35301
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d98209b
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 7da8c49
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java 170dc72

Diff: https://reviews.apache.org/r/9266/diff/
Testing
-------

Added unit tests for the cases being fixed. All current tests pass.
Thanks,

Hari Shreedharan

+
Hari Shreedharan 2013-02-02, 01:55
+
Hari Shreedharan 2013-02-02, 01:57
+
Hari Shreedharan 2013-02-02, 06:46
+
Mike Percy 2013-05-08, 21:58