Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures


+
Mengwei Ding 2013-07-17, 22:33
+
Mengwei Ding 2013-07-18, 17:09
+
Jarek Cecho 2013-07-21, 16:38
+
Mengwei Ding 2013-07-22, 17:27
+
Mengwei Ding 2013-07-22, 17:27
+
Mengwei Ding 2013-07-22, 17:33
+
Mengwei Ding 2013-07-22, 17:29
+
Mengwei Ding 2013-07-22, 21:36
+
Mengwei Ding 2013-07-23, 18:44
+
Mengwei Ding 2013-07-24, 17:55
+
Jarek Cecho 2013-07-28, 15:43
Copy link to this message
-
Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures


> On July 28, 2013, 3:43 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/common/EventContext.java, line 18
> > <https://reviews.apache.org/r/12713/diff/4/?file=327466#file327466line18>
> >
> >     This class seems to be strictly related to server component and as a result should not be available in the common module that is shared between client and server. I would suggest to create a new package "org.apache.sqoop.request" for it in module "core".

fixed.
> On July 28, 2013, 3:43 p.m., Jarek Cecho wrote:
> > common/src/main/java/org/apache/sqoop/common/EventContext.java, lines 26-36
> > <https://reviews.apache.org/r/12713/diff/4/?file=327466#file327466line26>
> >
> >     I believe that the EventContext do not need to be serialized anywhere and the access to each item should be as fast as possible as it will be done in each request. As a result I would suggest to use a normal properties rather then the Map. I believe that this context do not even need to extend the MutableMapContext class due to it's very specific use case.
> >    
> >     Can we also rename the class a bit to more descriptive about the usage? Perhaps HttpEventContext or something similar.

Renamed it to HttpEventContext. And compose a HashMap<String, String> to hold everything.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review24060
-----------------------------------------------------------
On Aug. 2, 2013, 9:36 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 9:36 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit b524404b665b296462365e6823f24347f40f1462
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed Jul 17 10:48:05 2013 -0700
>
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
>
> :100644 100644 999790d... beb08d5... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 94f92b3... b3cdbcb... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 97a240b... 8e6d77d... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... 10b3130... M client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 1a8f963... 91a4afe... M client/src/main/resources/client-resource.properties
> :100644 100644 a014ddd... 688bb64... M common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 4685797... 1555bd5... M common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 61d6576... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 3daf8d2... 9558941... M common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 5524983... f693d46... M common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 2f2b974... 19f81a8... M common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... d87655e... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 bf103e4... f3d4166... M common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 d0a087d... 733b201... M core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :000000 100644 0000000... 15beed0... A core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
> :100644 100644 f025ee9... f6bd5b5... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
+
Mengwei Ding 2013-08-02, 21:36
+
Mengwei Ding 2013-08-14, 17:32
+
Mengwei Ding 2013-08-14, 20:42
+
Jarek Cecho 2013-08-14, 22:27
+
Jarek Cecho 2013-08-14, 20:12
+
Jarek Cecho 2013-08-14, 01:00