-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9493/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

Correcting Sqoop user-guide troubleshooting section to add verbage to make sure users are aware that '--driver' flag should not be used with connection managers as it will default to the default connection manager if that flag is set.
This addresses bug Sqoop-626.
    https://issues.apache.org/jira/browse/Sqoop-626
Diffs
-----

  src/docs/user/troubleshooting.txt be43541

Diff: https://reviews.apache.org/r/9493/diff/
Testing
-------

Standard tests run, docs built successfully.
Thanks,

Linden Hillenbrand

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9493/#review16710
-----------------------------------------------------------
Hi Linden,
thank you very much for putting this together. I believe that it might be quite helpful for Sqoop users. Some high level notes:

1) Can you change escaping of keywords and driver names from double quotes to "+"? It should be typeset as a keyword in generated document and I believe that it will result in more readable text.

2) I'm not sure that usage of --driver keyword will lead to the same exception in all connectors. I would recommend to only mention that --driver parameter will force Sqoop to use generic jdbc connector instead of the special one which might lead to performance issues and/or errors in the processing.

Jarcec

- Jarek Cecho
On Feb. 18, 2013, 3:17 p.m., Linden Hillenbrand wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9493/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 3:17 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Correcting Sqoop user-guide troubleshooting section to add verbage to make sure users are aware that '--driver' flag should not be used with connection managers as it will default to the default connection manager if that flag is set.
>
>
> This addresses bug Sqoop-626.
>     https://issues.apache.org/jira/browse/Sqoop-626
>
>
> Diffs
> -----
>
>   src/docs/user/troubleshooting.txt be43541
>
> Diff: https://reviews.apache.org/r/9493/diff/
>
>
> Testing
> -------
>
> Standard tests run, docs built successfully.
>
>
> Thanks,
>
> Linden Hillenbrand
>
>

> On Feb. 18, 2013, 4:22 p.m., Jarek Cecho wrote:
> > Hi Linden,
> > thank you very much for putting this together. I believe that it might be quite helpful for Sqoop users. Some high level notes:
> >
> > 1) Can you change escaping of keywords and driver names from double quotes to "+"? It should be typeset as a keyword in generated document and I believe that it will result in more readable text.
> >
> > 2) I'm not sure that usage of --driver keyword will lead to the same exception in all connectors. I would recommend to only mention that --driver parameter will force Sqoop to use generic jdbc connector instead of the special one which might lead to performance issues and/or errors in the processing.
> >
> > Jarcec

Absolutely you're right, that makes more sense to users as well. I believe I just mis-typed the summary but I'll review my section and make sure it's not the connection manager but the issue of using the generic JDBC driver.

In addition I will modify to use '+'.

Thanks Jarcec!
- Linden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9493/#review16710
-----------------------------------------------------------
On Feb. 18, 2013, 3:17 p.m., Linden Hillenbrand wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9493/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 3:17 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Correcting Sqoop user-guide troubleshooting section to add verbage to make sure users are aware that '--driver' flag should not be used with connection managers as it will default to the default connection manager if that flag is set.
>
>
> This addresses bug Sqoop-626.
>     https://issues.apache.org/jira/browse/Sqoop-626
>
>
> Diffs
> -----
>
>   src/docs/user/troubleshooting.txt be43541
>
> Diff: https://reviews.apache.org/r/9493/diff/
>
>
> Testing
> -------
>
> Standard tests run, docs built successfully.
>
>
> Thanks,
>
> Linden Hillenbrand
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9493/
-----------------------------------------------------------

(Updated Feb. 18, 2013, 4:37 p.m.)
Review request for Sqoop, Jarek Cecho and Kathleen Ting.
Changes
-------

Adding Kathleen & Jarcec as reviewers, thank you.
Description
-------

Correcting Sqoop user-guide troubleshooting section to add verbage to make sure users are aware that '--driver' flag should not be used with connection managers as it will default to the default connection manager if that flag is set.
This addresses bug Sqoop-626.
    https://issues.apache.org/jira/browse/Sqoop-626
Diffs
-----

  src/docs/user/troubleshooting.txt be43541

Diff: https://reviews.apache.org/r/9493/diff/
Testing
-------

Standard tests run, docs built successfully.
Thanks,

Linden Hillenbrand

> On Feb. 18, 2013, 4:22 p.m., Jarek Cecho wrote:
> > Hi Linden,
> > thank you very much for putting this together. I believe that it might be quite helpful for Sqoop users. Some high level notes:
> >
> > 1) Can you change escaping of keywords and driver names from double quotes to "+"? It should be typeset as a keyword in generated document and I believe that it will result in more readable text.
> >
> > 2) I'm not sure that usage of --driver keyword will lead to the same exception in all connectors. I would recommend to only mention that --driver parameter will force Sqoop to use generic jdbc connector instead of the special one which might lead to performance issues and/or errors in the processing.
> >
> > Jarcec
>
> Linden Hillenbrand wrote:
>     Absolutely you're right, that makes more sense to users as well. I believe I just mis-typed the summary but I'll review my section and make sure it's not the connection manager but the issue of using the generic JDBC driver.
>    
>     In addition I will modify to use '+'.
>    
>     Thanks Jarcec!

Agreed. That error message was specifically seen with Oracle. A similar one may be seen with DB2, HSQLDB, MySQL, PostgresSQL, or Microsoft SQL Server.

How about this?

While working with Oracle, DB2, HSQLDB, MySQL, PostgresSQL, or Microsoft SQL Server, you may encounter a problem when the Sqoop command explicitly specifies the --driver <driver name> option. That is, when the driver option is included in the Sqoop command, the built-in connection manager selection defaults to the generic connection manager, which causes this issue. If the driver option is not specified, the built-in connection manager selection mechanism selects the appropriate specific connection manager which generates valid SQL and uses the driver "oracle.jdbc.OracleDriver", "com.ibm.db2.jcc.DB2Driver", "org.hsqldb.jdbcDriver", "com.mysql.jdbc.Driver", "org.postgresql.Driver", or "com.microsoft.sqlserver.jdbc.SQLServerDriver" respectively.
- Kathleen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9493/#review16710
-----------------------------------------------------------
On Feb. 18, 2013, 4:37 p.m., Linden Hillenbrand wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9493/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 4:37 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho and Kathleen Ting.
>
>
> Description
> -------
>
> Correcting Sqoop user-guide troubleshooting section to add verbage to make sure users are aware that '--driver' flag should not be used with connection managers as it will default to the default connection manager if that flag is set.
>
>
> This addresses bug Sqoop-626.
>     https://issues.apache.org/jira/browse/Sqoop-626
>
>
> Diffs
> -----
>
>   src/docs/user/troubleshooting.txt be43541
>
> Diff: https://reviews.apache.org/r/9493/diff/
>
>
> Testing
> -------
>
> Standard tests run, docs built successfully.
>
>
> Thanks,
>
> Linden Hillenbrand
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9493/
-----------------------------------------------------------

(Updated March 28, 2013, midnight)
Review request for Sqoop, Jarek Cecho and Kathleen Ting.
Changes
-------

Updated as per Kathleen's suggestions.
Description
-------

Correcting Sqoop user-guide troubleshooting section to add verbage to make sure users are aware that '--driver' flag should not be used with connection managers as it will default to the default connection manager if that flag is set.
This addresses bug Sqoop-626.
    https://issues.apache.org/jira/browse/Sqoop-626
Diffs (updated)
-----

  src/docs/user/troubleshooting.txt be43541

Diff: https://reviews.apache.org/r/9493/diff/
Testing
-------

Standard tests run, docs built successfully.
Thanks,

Linden Hillenbrand

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9493/#review18468
-----------------------------------------------------------
Hi Linden, thank you for your contribution. Can you please clean up the whitespace characters at the end of each sentence? Also, would it be possible to break this into separate 'problem' and 'solution' subsections as we have for the other troubleshooting issues? Thank you.

- Kathleen Ting
On March 28, 2013, midnight, Linden Hillenbrand wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9493/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, midnight)
>
>
> Review request for Sqoop, Jarek Cecho and Kathleen Ting.
>
>
> Description
> -------
>
> Correcting Sqoop user-guide troubleshooting section to add verbage to make sure users are aware that '--driver' flag should not be used with connection managers as it will default to the default connection manager if that flag is set.
>
>
> This addresses bug Sqoop-626.
>     https://issues.apache.org/jira/browse/Sqoop-626
>
>
> Diffs
> -----
>
>   src/docs/user/troubleshooting.txt be43541
>
> Diff: https://reviews.apache.org/r/9493/diff/
>
>
> Testing
> -------
>
> Standard tests run, docs built successfully.
>
>
> Thanks,
>
> Linden Hillenbrand
>
>