Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Zookeeper >> mail # dev >> Re: Review Request 12983: ZOOKEEPER-1691


+
Helen Hastings 2013-08-19, 21:26
+
Edward Ribeiro 2013-08-20, 00:39
+
Helen Hastings 2013-08-21, 22:09
+
Edward Ribeiro 2013-08-20, 02:00
+
Edward Ribeiro 2013-08-20, 02:03
+
Edward Ribeiro 2013-08-20, 02:02
+
Edward Ribeiro 2013-08-20, 02:08
+
Edward Ribeiro 2013-08-20, 02:25
+
Edward Ribeiro 2013-08-20, 02:13
+
Edward Ribeiro 2013-08-20, 02:31
+
Helen Hastings 2013-08-21, 22:11
+
Edward Ribeiro 2013-08-22, 00:14
+
Helen Hastings 2013-08-21, 22:11
Copy link to this message
-
Re: Review Request 12983: ZOOKEEPER-1691

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12983/#review25790
-----------------------------------------------------------
Hi Helen,

thanks for the changes. I have one remaining comment - basically I'd like to understand your change in FastLeaderElection and see if we can improve it or if not at least explain it in the code.

Thanks,
Alex
http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
<https://reviews.apache.org/r/12983/#comment50316>

    Can you please explain why termPredicate doesn't work in this case, requiring this fix ?
    
    Where do you check that 2 out of 2 are following the same leader ?
    
    Intuitively I would prefer to understand why termpredicate doesn't work for the case of 2 and whether we can fix it or "containsQuorum" in the quorum verifiers implementations.
- Alexander Shraer
On Aug. 21, 2013, 10:11 p.m., Helen Hastings wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12983/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2013, 10:11 p.m.)
>
>
> Review request for zookeeper and Alexander Shraer.
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> Added standaloneEnabled flag to QuorumPeerConfig to give the option to disable standalone mode for a single server.
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java PRE-CREATION
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java 1516310
>   http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StandaloneTest.java 1516310
>
> Diff: https://reviews.apache.org/r/12983/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Helen Hastings
>
>

+
Helen Hastings 2013-10-01, 04:02
+
Alexander Shraer 2013-10-03, 04:54
+
Helen Hastings 2013-12-14, 00:00
+
Helen Hastings 2013-12-14, 00:02
+
Helen Hastings 2014-01-07, 04:32
+
Raul Gutierrez Segales 2014-01-17, 18:51