Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
MapReduce >> mail # dev >> [Vote] Merge branch-trunk-win to trunk


Copy link to this message
-
Re: [Vote] Merge branch-trunk-win to trunk
Didn't I explain in details what I am asking for?

Thanks,
--Konst

On Sun, Mar 3, 2013 at 11:08 AM, Matt Foley <[EMAIL PROTECTED]> wrote:
> Hi Konstantin,
> I'd like to point out two things:
> First, I already committed in this thread (email of Thu, Feb 28, 2013 at
> 6:01 PM) to providing CI for Windows builds.  So please stop acting like I'm
> resisting this idea or something.
> Second, you didn't answer my question, you just kvetched about the phrasing.
> So I ask again:
>
> Will providing full "test-patch" integration (pre-commit build and unit test
> triggered by Jira "Patch Available" state) satisfy your request for
> functionality #1 and #2?  Yes or no, please.
>
> Thanks,
> --Matt
>
>
> On Sat, Mar 2, 2013 at 7:32 PM, Konstantin Shvachko <[EMAIL PROTECTED]>
> wrote:
>>
>> Hi Matt,
>>
>> On Sat, Mar 2, 2013 at 12:32 PM, Matt Foley <[EMAIL PROTECTED]>
>> wrote:
>> > Konstantin,
>> > I would like to explore what it would take to remove this perceived
>> > impediment --
>>
>> Glad you decided to explore. Thank you.
>>
>> > although I reserve the right to argue that this is not
>> > pre-requisite to merging the cross-platform support patch.
>>
>> It's your right indeed. So as mine to question what the platform
>> support means for you, which I believe remained unclear.
>> I do not impede the change as you should have noticed. My requirement
>> comes from my perception of the support, which means to me exactly two
>> things:
>> 1. The ability to recognise the code is broken for the platform
>> 2. The ability to test new patches on the platform
>> The latter is problematic, as many noticed in this thread, for those
>> whose customary environment does not include Windows.
>>
>> > If we implemented full "test-patch" support for Windows on trunk, would
>> > that
>> > fulfill both your items #1 and #2?  Please note that:
>> > a) Pushing the "Patch Available" button in Jira shall cause a pre-commit
>> > build to start within, I believe, 20 minutes.
>> > b) That build keeps logs for both java build and unit tests for several
>> > days, that are accessible to all viewers.
>>
>> In item #1 I mostly asking for the nightly build, which is simpler
>> than "test-patch". The latter would be ideal from the platform support
>> viewpoint, but it is for the community to decide if we want to add
>> extra +3 hours to the build.
>> Nightly build in my understanding is triggered by the timer rather
>> than by Jira's "submit patch" button.  On Jenkins build configuration
>> you can specify it under "Build periodically".
>>
>> > So, does this provide sufficient on-demand support that we don't have to
>> > implement a whole new on-demand VM support structure of some sort for #2
>> > (which would be an extraordinary and impractical demand)?
>>
>> I did not mention VMs. Item #2 means a build, which runs "test-patch"
>> target with the file specified by a user (instead of a jira
>> attachment).
>> When user clicks "Build Now" link a box is displayed where the user
>> can enter the file path containing the patch. This can be specified in
>> the Build Configuration under "This build is parameterized" by
>> choosing AddParameter / FileParameter. The build can run on the same
>> Windows machine as the nightly build.
>> Such build will let people test their patches for Windows on Jenkins
>> if they don't posses a license for the right version of Windows.
>> I hope this will not turn into extraordinary or impractical effort.
>>
>> Thanks,
>> --Konst
>>
>> > Thanks,
>> > --Matt
>> >
>> >
>> > On Fri, Mar 1, 2013 at 12:18 PM, Konstantin Shvachko
>> > <[EMAIL PROTECTED]>
>> > wrote:
>> >>
>> >> -1
>> >> We should have a CI infrastructure in place before we can commit to
>> >> supporting Windows platform.
>> >>
>> >> Eric is right Win/Cygwin was supported since day one.
>> >> I had a Windows box under my desk running nightly builds back in
>> >> 2006-07.
>> >> People were irritated but I was filing windows bugs until 0.22 release.
>> >> Times changing and I am glad to see wider support for Win platform.
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB