Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender


Copy link to this message
-
Re: Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender
Hari Shreedharan 2012-12-22, 22:54


> On Dec. 10, 2012, 7:45 p.m., Hari Shreedharan wrote:
> > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java, lines 65-68
> > <https://reviews.apache.org/r/8328/diff/2/?file=235858#file235858line65>
> >
> >     Why make this package private?
>
> Brock Noland wrote:
>     Hi,
>    
>     Just curious, is this the only thing holding this patch up?

I was expecting the contributor to come back with this change. Since he has not, I think we can commit this. I'd like to review this once more and commit this.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8328/#review14257
-----------------------------------------------------------
On Dec. 7, 2012, 8:12 p.m., Cameron Gandevia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8328/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2012, 8:12 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> The Log4jAppender should be extended to use the LoadBalancingRpcClient allowing users to configure a load balancing log4jappender
>
>
> Diffs
> -----
>
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 083f5d1
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-backoff-log4jtest.properties PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-rnd-log4jtest.properties PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancinglog4jtest.properties PRE-CREATION
>   flume-ng-doc/sphinx/FlumeUserGuide.rst f8528bb
>
> Diff: https://reviews.apache.org/r/8328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Cameron Gandevia
>
>