Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request 12239: Fix for SQOOP-1112


Copy link to this message
-
Re: Review Request 12239: Fix for SQOOP-1112
Jarek Cecho 2013-07-02, 23:29

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12239/#review22695
-----------------------------------------------------------

Ship it!
Ship It!

- Jarek Cecho
On July 2, 2013, 9:11 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12239/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 9:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> When we worked on SQOOP-1080, we did not take into consideration the daylight savings offsets.  This patch fixes it.
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java 0bb979e
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java 1a3601a
>
> Diff: https://reviews.apache.org/r/12239/diff/
>
>
> Testing
> -------
>
> Modified tests to use the paramters that exposed this bug and verified that date partitioning works as expected
>
>
> Thanks,
>
> Venkat Ranganathan
>
>