Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request 15765: SQOOP-1242 Shell option errors not displayed and client error not printed


+
Vasanth kumar RJ 2013-11-21, 20:44
+
Vasanth kumar RJ 2013-11-22, 15:36
Copy link to this message
-
Re: Review Request 15765: SQOOP-1242 Shell option errors not displayed and client error not printed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15765/#review29250
-----------------------------------------------------------
Looks good except for a nit below!
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java
<https://reviews.apache.org/r/15765/#comment56394>

    You can shorten this a bit:
    
    line = FormOptions.parseOptions(this, 1, args, !isInteractive());
- Abraham Elmahrek
On Nov. 21, 2013, 8:44 p.m., Vasanth kumar RJ wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15765/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 8:44 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1242
>     https://issues.apache.org/jira/browse/SQOOP-1242
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> In shell interactive model, no error message is thrown when wrong option is used in sqoop command.
>
> Shell is not displaying the server error message in shell:
> Example:
> sqoop:000> show job -jid 2
> Exception has occurred during processing command
> Exception: org.apache.sqoop.common.SqoopException Message: CLIENT_0001:Server has returned exception
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/request/Request.java d9229f5
>   shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
>
> Diff: https://reviews.apache.org/r/15765/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Vasanth kumar RJ
>
>