Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Zookeeper >> mail # dev >> Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)


Copy link to this message
-
Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)


> On Jan. 9, 2013, 7:13 p.m., Patrick Hunt wrote:
> > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, line 1210
> > <https://reviews.apache.org/r/8094/diff/4/?file=244377#file244377line1210>
> >
> >     is there a configuration option to disable this feature? I don't see any doc details on this...
> >    
> >     admin.enableAdminServer  seems to be missing?

I somehow managed to document admin.enableAdminServer in my latest patch to the JIRA but not here... regardless it's there now.
> On Jan. 9, 2013, 7:13 p.m., Patrick Hunt wrote:
> > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, line 1211
> > <https://reviews.apache.org/r/8094/diff/4/?file=244377#file244377line1211>
> >
> >     this should be "New in 3.5.0", won't get into a fix release.

Done.
> On Jan. 9, 2013, 7:13 p.m., Patrick Hunt wrote:
> > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, line 1234
> > <https://reviews.apache.org/r/8094/diff/4/?file=244377#file244377line1234>
> >
> >     isn't "/" root? Not sure what you mean by "for now nothing is served directly from the root"

Hmm not sure if root is or isn't the right term here.

I mean right now everything happens at "/commands" (by default) and "/" is a 404. I'm tempted to remove this option altogether and only have the command URL option for simplicity.
- Skye
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8094/#review15204
-----------------------------------------------------------
On Jan. 4, 2013, 2:17 a.m., Skye Wanderman-Milne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8094/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2013, 2:17 a.m.)
>
>
> Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry Robinson.
>
>
> Description
> -------
>
> See my comment in ZOOKEEPER-1346.
>
>
> This addresses bug ZOOKEEPER-1346.
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1346
>
>
> Diffs
> -----
>
>   ivy.xml fadf4f4
>   src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 47190a8
>   src/java/main/org/apache/zookeeper/server/DataTree.java d6c7773
>   src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 130c58e
>   src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 9422538
>   src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java eec2f2a
>   src/java/main/org/apache/zookeeper/server/ServerCnxn.java 35ea301
>   src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 267dbdf
>   src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f
>   src/java/main/org/apache/zookeeper/server/SessionTracker.java 3535e1b
>   src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 137862e
>   src/java/main/org/apache/zookeeper/server/WatchManager.java 0e7c815
>   src/java/main/org/apache/zookeeper/server/ZKDatabase.java d6c0c05
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 14e754b
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 369e621
>   src/java/main/org/apache/zookeeper/server/ZooTrace.java ac14fe2
>   src/java/main/org/apache/zookeeper/server/admin/AdminServer.java PRE-CREATION
>   src/java/main/org/apache/zookeeper/server/admin/AdminServerFactory.java PRE-CREATION
>   src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION
>   src/java/main/org/apache/zookeeper/server/admin/CommandBase.java PRE-CREATION
>   src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java PRE-CREATION
>   src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION
>   src/java/main/org/apache/zookeeper/server/admin/DummyAdminServer.java PRE-CREATION
>   src/java/main/org/apache/zookeeper/server/admin/JettyAdminServer.java PRE-CREATION