Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1726. HBase sink security support


+
Hari Shreedharan 2012-12-05, 23:46
+
Hari Shreedharan 2012-12-06, 07:48
+
Matteo Bertozzi 2012-12-06, 17:39
+
Brock Noland 2012-12-06, 18:45
+
Hari Shreedharan 2012-12-06, 19:22
Copy link to this message
-
Re: Review Request: FLUME-1726. HBase sink security support

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8365/#review14101
-----------------------------------------------------------
Looks good!  A couple more comments/questions below.  Also, it looks like we could unit test a fair amount of  HBaseSinkSecurityManager even if we cannot unit test the actual kerberos login portion at this time? Do you think that is possible?
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java
<https://reviews.apache.org/r/8365/#comment30172>

    Nit: Empty javadoc comment

flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java
<https://reviews.apache.org/r/8365/#comment30171>

    Nit: Should we remove the return statement or fill it in?

flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java
<https://reviews.apache.org/r/8365/#comment30169>

    This method will only be called when security is enabled correct?
    
    Assuming that is true do we want to return null from this method because the subsequent call to hbase will fail with an error message anyway, correct?

flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java
<https://reviews.apache.org/r/8365/#comment30170>

    Nit: Looks like there is a space missing in the error message.
- Brock Noland
On Dec. 6, 2012, 7:22 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8365/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2012, 7:22 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Did some basic testing against secure and non-secure hbase. I will update this patch as I test. This is an initial patch only, changes are likely.
>
>
> This addresses bug FLUME-1726.
>     https://issues.apache.org/jira/browse/FLUME-1726
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-ng-hbase-sink/pom.xml 25422e1
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 021ecd0
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 62f7097
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>

+
Hari Shreedharan 2012-12-06, 19:54
+
Hari Shreedharan 2012-12-06, 19:55