Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-892 Sqoop2: Validate acceptable number of mappers and reducers


+
Jarek Cecho 2013-02-15, 23:41
Copy link to this message
-
Re: Review Request: SQOOP-892 Sqoop2: Validate acceptable number of mappers and reducers
Cheolsoo Park 2013-02-22, 19:58

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9479/#review16958
-----------------------------------------------------------
Looks good. I have a minor comment regarding the error messages.
core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java
<https://reviews.apache.org/r/9479/#comment35935>

    Can you change the message to something like "The throttling threshold must be greater than 1"?

core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java
<https://reviews.apache.org/r/9479/#comment35936>

    Same as above.
- Cheolsoo Park
On Feb. 15, 2013, 11:41 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9479/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2013, 11:41 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've improved the Framework validator as suggested.
>
>
> This addresses bug SQOOP-892.
>     https://issues.apache.org/jira/browse/SQOOP-892
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java 6f9a6fca7d95de7aa098c2e094fd98bb744a49b6
>   core/src/main/java/org/apache/sqoop/framework/configuration/ExportJobConfiguration.java d533089c4602fd7740502b6d1607ba0716acf6bb
>   core/src/test/java/org/apache/sqoop/framework/TestFrameworkValidator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9479/diff/
>
>
> Testing
> -------
>
> I've included new unit test + tested on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

+
Jarek Cecho 2013-02-23, 17:28
+
Cheolsoo Park 2013-02-24, 03:17
+
Cheolsoo Park 2013-02-24, 03:17