Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request 14537: Patch for FLUME-2120


Copy link to this message
-
Review Request 14537: Patch for FLUME-2120
Venkatesh Sivasubramanian... 2013-10-08, 16:45

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14537/
-----------------------------------------------------------

Review request for Flume.
Repository: Flume
Description
-------

Pls. find the patch attached for the FLUME-2120.

I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.
Diffs
-----
Diff: https://reviews.apache.org/r/14537/diff/
Testing
-------

JUnit added for SyslogUDPSource.
File Attachments
----------------

FLUME-2120.patch
  https://reviews.apache.org/media/uploaded/files/2013/10/08/FLUME-2120.patch
Thanks,

Venkatesh Sivasubramanian