Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 16020: Fix for SQOOP-1249


Copy link to this message
-
Re: Review Request 16020: Fix for SQOOP-1249


> On Dec. 4, 2013, 11:36 p.m., Jarek Cecho wrote:
> > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java, line 176
> > <https://reviews.apache.org/r/16020/diff/1/?file=394162#file394162line176>
> >
> >     Nit: The method do not seem to be used.

Thanks Jarcec.
> On Dec. 4, 2013, 11:36 p.m., Jarek Cecho wrote:
> > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java, line 301
> > <https://reviews.apache.org/r/16020/diff/1/?file=394162#file394162line301>
> >
> >     Nit: The parameter isQuery do not seem to be used.

Thanks Jarcec
- Venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16020/#review29774
-----------------------------------------------------------
On Dec. 4, 2013, 10:54 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16020/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 10:54 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1249
>     https://issues.apache.org/jira/browse/SQOOP-1249
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix for Sqoop-1249.   The validation has been fixed to allow one of target-dir or hcatalog|hbase|accumulo table as the destination
>
> Added one more test case for query imports into a hcatalog table
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/tool/ImportTool.java 50826e9
>   src/test/org/apache/sqoop/hcat/HCatalogImportTest.java 13850fc
>
> Diff: https://reviews.apache.org/r/16020/diff/
>
>
> Testing
> -------
>
> Ran all tests and checkstyle verification
>
>
> Thanks,
>
> Venkat Ranganathan
>
>