-Re: FilterList: possible bug in getNextKeyHint
Ted Yu 2013-07-29, 23:36
Can you log a JIRA and attach the patches there ?
Your attachments did not go through.
On Mon, Jul 29, 2013 at 4:34 PM, Viral Bajaria <[EMAIL PROTECTED]>wrote:
> Attached are 2 patches: one of them is TestFail.patch where I show that
> the behavior is not as expected. On the other hand, the second patch is
> with the changes that I did to FilterList and the behavior is as expected.
> I have tested the state maintenance on two filters that implement
> getNextKeyHint but not on 3. I doubt that would break though. The part that
> I am most skeptical about is MUST_PASS_ONE since we can't bail out the
> filterKeyValue call as soon as we see the SEEK_NEXT_USING_HINT and so need
> that extra if statement before returning the ReturnCode.
> Let me know if something is not clear or as expected.
> On Mon, Jul 29, 2013 at 10:49 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
>> Looking into FilterList#filterKeyValue() and FilterList#getNextKeyHint(),
>> they both iterate through all the filters.
>> Suppose there are 3 or more filters in the FilterList which implement
>> getNextKeyHint(), how would the state be maintained ?