Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 15166: ACCUMULO-802 Tablespaces


Copy link to this message
-
Re: Review Request 15166: ACCUMULO-802 Tablespaces

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15166/#review28561
-----------------------------------------------------------

core/src/main/java/org/apache/accumulo/core/client/TableNamespaceExistsException.java
<https://reviews.apache.org/r/15166/#comment55382>

    Can we shorten TableNamespace to just Namespace?  

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperations.java
<https://reviews.apache.org/r/15166/#comment55384>

    This might be a good place to provide some information about the default namespace and its behavior.  Or at least point out its existance and refer to the user manual.
    
    

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperations.java
<https://reviews.apache.org/r/15166/#comment55385>

    I am curious if this method returns the default namespace.

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperations.java
<https://reviews.apache.org/r/15166/#comment55386>

    Should we document what namespace names are valid here?

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperations.java
<https://reviews.apache.org/r/15166/#comment55387>

    would it be more accurate to state that tables created in this namespace will use this setting if not specified?

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperations.java
<https://reviews.apache.org/r/15166/#comment55390>

    API call was added to tableOperations to wait for online and offline

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperationsImpl.java
<https://reviews.apache.org/r/15166/#comment55394>

    Might be good to refactor this code so that namespace and table operations use the same code to execute remote fate operations.

core/src/main/java/org/apache/accumulo/core/client/admin/TableNamespaceOperationsImpl.java
<https://reviews.apache.org/r/15166/#comment55393>

    If the client dies it will leave the clone incomplete.  There could also be concurrency issue since this is driven from the client side.  Like a table being deleted while clone is running.

core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java
<https://reviews.apache.org/r/15166/#comment55395>

    Doing this on the client side is susceptible to race conditions.

core/src/main/java/org/apache/accumulo/core/client/impl/Tables.java
<https://reviews.apache.org/r/15166/#comment55400>

    I think the mapping from namespace id to namespace name should be resolved once in this method... that way the method will give a consistent view in the face of namespace renames

core/src/main/java/org/apache/accumulo/core/client/impl/Tables.java
<https://reviews.apache.org/r/15166/#comment55398>

    should not use jlin logger... should not just log an error here
- kturner
On Nov. 1, 2013, 2:01 a.m., Christopher Tubbs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15166/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 2:01 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-802
>     https://issues.apache.org/jira/browse/ACCUMULO-802
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-802 Tablespaces (Table Namespaces), work done by Sean Hickey, https://github.com/Wisellama/accumulo/tree/ACCUMULO-802, rebase'd onto latest master (including 210 commits)
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/accumulo/core/Constants.java 9db0c405c5b9fbac13fa735c3ffd6433e9831051
>   core/src/main/java/org/apache/accumulo/core/client/Connector.java bbfa55f4b9ad8fc0e5f0c0058e2e0564685d7c85
>   core/src/main/java/org/apache/accumulo/core/client/TableNamespaceExistsException.java PRE-CREATION
>   core/src/main/java/org/apache/accumulo/core/client/TableNamespaceNotEmptyException.java PRE-CREATION