Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-894 Sqoop2: Increase counter and group size in derby repository


Copy link to this message
-
Re: Review Request: SQOOP-894 Sqoop2: Increase counter and group size in derby repository
Cheolsoo Park 2013-02-14, 17:52

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9448/#review16592
-----------------------------------------------------------

Ship it!
LGTM

- Cheolsoo Park
On Feb. 14, 2013, 5:46 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9448/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 5:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've increased the size of counter and group name from 50 to 75 and make provide truncating methods into queries, so that they won't fail.
>
>
> This addresses bug SQOOP-894.
>     https://issues.apache.org/jira/browse/SQOOP-894
>
>
> Diffs
> -----
>
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java d94ecc56ae07fab71a0b04223e00984e07b97ce9
>
> Diff: https://reviews.apache.org/r/9448/diff/
>
>
> Testing
> -------
>
> Maven tests seems to be passing + tested on real cluster
>
>
> Thanks,
>
> Jarek Cecho
>
>