Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 15518: ACCUMULO-1878 handle error conditions in example tests.


Copy link to this message
-
Re: Review Request 15518: ACCUMULO-1878 handle error conditions in example tests.
Sean Busbey 2013-11-14, 16:52

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15518/
-----------------------------------------------------------

(Updated Nov. 14, 2013, 4:52 p.m.)
Review request for accumulo.
Bugs: ACCUMULO-1878
    https://issues.apache.org/jira/browse/ACCUMULO-1878
Repository: accumulo
Description
-------

ACCUMULO-1878 handle error conditions in example tests.

* ensure simple examples used in integration tests properly set non-zero exit on errors
* check return code of executed commands.
* fix typo in bloom filter speed comparison
* fix error in arg order on helloworld examples
* Makes sure paired examples for RandomBatch use the same seed.
Diffs
-----

  src/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java 7801104bf5b8095066630512a0b44bc8af2a85bf
  src/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchWriter.java 3206fa6bbb5e560175e9aec6a1e612185e4ca945
  test/system/auto/simple/examples.py 5fc9b4bdee7f24beba0d85f414600afffa8d0b08

Diff: https://reviews.apache.org/r/15518/diff/
Testing (updated)
-------

unit tests pass. functional test simple.examples.Examples passes, presuming the fixes for ACCUMULO-1891 and ACCUMULO-1892 are in place.

I get rare on-VM flakiness on the bloom filter /no bloom speed comparison.

I was getting loud failure on the non-isolated scanner interference example, but it mysteriously stopped happening. I presume it was VM related. I have stack traces still, so I could file a follow on ticket if there's interest.
Thanks,

Sean Busbey