Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 16081: ACCUMULO-1958 - Safer Range constructor


Copy link to this message
-
Re: Review Request 16081: ACCUMULO-1958 - Safer Range constructor
keith@... 2013-12-12, 15:31

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16081/#review30260
-----------------------------------------------------------

Ship it!
Ship It!

- kturner
On Dec. 9, 2013, 4:18 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16081/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2013, 4:18 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1958
>     https://issues.apache.org/jira/browse/ACCUMULO-1958
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Based on Sean's strategy, creates a new protected Range constructor without the start/stop key check, and adds the check to the public six-argument constructor. Opted not to deprecate the public constructor at this time, since it is now safe.
>
>
> Diffs
> -----
>
>   src/core/src/main/java/org/apache/accumulo/core/data/Range.java 7ef0dc5710877cdd0dd3ead69e7db5d8c9ef68c1
>   src/core/src/test/java/org/apache/accumulo/core/data/RangeTest.java a8d91b0944cdab6ff10ec0847fe999f0ce666631
>
> Diff: https://reviews.apache.org/r/16081/diff/
>
>
> Testing
> -------
>
> Unit testing for Range still passes.
>
>
> Thanks,
>
> Bill Havanki
>
>