Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: Fix SQOOP-1080


Copy link to this message
-
Re: Review Request: Fix SQOOP-1080

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11896/#review21959
-----------------------------------------------------------

Ship it!
Thank you for promptly fixing the issue Venkat!

- Jarek Cecho
On June 15, 2013, 10:39 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11896/
> -----------------------------------------------------------
>
> (Updated June 15, 2013, 10:39 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> The reason we have this failure is because the hosts running the jenkins CI runs are all set to Etc/UTC timezone which never has daylight saving time  (For example see https://builds.apache.org/computer/ubuntu6/systemInfo) .   To fix this, I have denormalized  the time to UTC time from local time ( as the time we read in is normalized) and print the time in UTC.   This will mean that we will have same partitions irrespective of whether a timezone observes DST or not.
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java eef18f2
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java 522a515
>
> Diff: https://reviews.apache.org/r/11896/diff/
>
>
> Testing
> -------
>
> Ran the complete tests with various timezones to check this
>
>
> Thanks,
>
> Venkat Ranganathan
>
>