Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 14490: HIVE-5372: Refactor TypeInfo and PrimitiveTypeEntry class hierachy to eliminate info repetition


Copy link to this message
-
Re: Review Request 14490: HIVE-5372: Refactor TypeInfo and PrimitiveTypeEntry class hierachy to eliminate info repetition

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14490/#review26707
-----------------------------------------------------------
Nice, this looks much cleaner. I'll try to take another look later but overall this looks good changes.

serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
<https://reviews.apache.org/r/14490/#comment52020>

    Here you might have to pass in the TypeInfo. Test out stuff like cast('abc' as varchar(10)) - if it's not done right then the TypeInfo for that expression shows up as varchar(3).

serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharUtils.java
<https://reviews.apache.org/r/14490/#comment52021>

    Maybe this can be combined with ParameterizedPrimitiveTypeUtils, or those methods can be moved here since they are all varchar-specific now.
- Jason Dere
On Oct. 4, 2013, 2:07 p.m., Xuefu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14490/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2013, 2:07 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-5372
>     https://issues.apache.org/jira/browse/HIVE-5372
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See JIRA comment https://issues.apache.org/jira/browse/HIVE-5372?focusedCommentId=13785506&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13785506
>
>
> Diffs
> -----
>
>   contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java 8fcb3b3
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java f8d1483
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java eb10360
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 628efab
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 36034d6
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java c8c5f63
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java af51072
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 6538add
>   ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java 9225aa1
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java 0ce1825
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java 366d9e6
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java 5ba2ec5
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java 509a392
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java 1bb164a
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 6815195
>   serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 5de5bd5
>   serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java a206023
>   serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java ac81ab8
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 67f032c
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java 1286cba
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 214a3e7
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/AbstractPrimitiveLazyObjectInspector.java 29c8528
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBinaryObjectInspector.java dbd60f7
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBooleanObjectInspector.java 954f1d9
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyByteObjectInspector.java 57c5169
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyDateObjectInspector.java 679e5ea